Repository navigation
Fix ActionRecord payload setter: use || instead of && - #29
Merged
Harry-Chen merged 1 commit intoMar 13, 2026
Merged
Conversation
The condition `actionIndex >= Action.values.length && actionIndex < 0` is always false since no value can be both >= length and < 0 at the same time. This means invalid action indices are never caught and would cause an out-of-bounds access on the next line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actionIndex >= Action.values.length && actionIndex < 0is always false (no integer can satisfy both conditions simultaneously)RangeErroronAction.values[actionIndex]&&to||so the check correctly rejects values outside[0, Action.values.length)Test plan
RangeErrorfrom the guard, not from list access