feature/120-uv-vis-fluorescence-examples#121
Conversation
|
|
I added also a fluorescence kinetics measurement in a 96well microtiter plate to illustrate, how high-throughput measurements could be handled with DCAT-AP-chem. |
|
after fixing the tests, the PR could be merged.... |
|
hi @markdoerr. Your test are currently failing because the testpipeline needs specific test file names to run correctly. Currentl, since we don't want to start every example from the dcat-ap root class, which should be cataloge, we choose the starting class, from which the test runner shall start, by naming the testfile after respective class, e.g. DatageneratingActivity-001, AnalysisDataset-001 a.s.o. If you change the names into e.g. NMR_Analysis_dataset, you would need to implement different testing mechanisms. While this is simple for the uv pytest command, the just test command, running the linkML inbuild _test_examples command, causes the issues here. |
|
Thanks for the hint, @HendrikBorgelt , They should be also programmatically callable (without a subprocess call) - if you have not done it before, I could have a look into it .... |
|
the uv pytest running tests/test_data.py, can simply be modified, without larger issues. however just test implements which I think causes an issue if you run it without the named schema files. I would need to do additional testing to check this. However, as far as I understand, this is the default test setup LinkML implements, so we should not deviate from this to much. (have a look at this issue linkml/linkml#2564) But maybe we need to discuss this with @StroemPhi and @dalito in more detail. |
In this PR we will add more common example datasets (to explore the capabilities of our framework):
UV-vis single sample, single measurement and microtiter plate example
UV-vis kinetics measurement example
corresponding Fluorescence measurement examples
Closes #120