modified the prefixes#135
Open
HendrikBorgelt wants to merge 2 commits into
Open
Conversation
Changed: - dcatapplus to dcat_ap_plus - chemdcatap to chem_dcat_ap and modified some of the prefixes as seen in nfdi-de/dcat-ap-plus#83 The tests should fail, because the prefix change on nfdi-de/dcat-ap-plus has not been rolled out yet, and therefore, the schema can't align the prefix mismatch Co-Authored-By: Philip Strömert <[email protected]>
Collaborator
Author
|
The tests are currently not failing because of wrong prefixes but because of issues in the pythongen linkML generator, which does not validate that a prefix conflicts with Python builtins. So the generator tries to convert |
Collaborator
Author
|
hopefully the issue gets resolved by linkml/linkml#3459 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed:
and modified some of the prefixes as seen in nfdi-de/dcat-ap-plus#83
The tests should fail, because the prefix change on nfdi-de/dcat-ap-plus has not been rolled out yet, and therefore, the schema can't align the prefix mismatch