-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addition of a few new concepts #112
addition of a few new concepts #112
Conversation
Sorry for the silence. I would like to define "sample" as here https://nfdi4cat.github.io/pid4cat-model/ResourceCategory/ - You could either remove it from your PR or we do it before merging. We'll add the definition from pid4cat this week in another PR. For mechanism: I think the preferred label should better not just be @nmoust - can you also have a look? |
Thanks for the quick reply @dalito, I have removed the sample concept and have made the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schumannj and @dalito I have no further comments. I think that the additions look good! Thanks for contributing!
I was missing a few concepts for annotating some quantities and sections in NOMAD: