This repository was archived by the owner on Aug 18, 2026. It is now read-only.
Bonfire: 1.0.1-beta.11 -> 1.0.6.alpha-1 - #2155
Closed
ju1m wants to merge 9 commits into
Closed
Conversation
jian-lin
reviewed
Feb 12, 2026
ju1m
changed the title
ju1m
marked this pull request as ready for review
February 19, 2026 07:00
ju1m
force-pushed
the
bonfire-update
branch
2 times, most recently
from
February 19, 2026 07:18
c1d9dfc to
ee5d627
Compare
ju1m
marked this pull request as draft
February 19, 2026 08:06
Author
|
Bonfire is currently broken without OpenID. |
imincik
previously approved these changes
Feb 20, 2026
ju1m
changed the title
ju1m
marked this pull request as draft
February 21, 2026 18:24
ju1m
force-pushed
the
bonfire-update
branch
2 times, most recently
from
February 22, 2026 00:55
a1c329b to
69e98a4
Compare
ju1m
marked this pull request as ready for review
February 22, 2026 00:56
ju1m
marked this pull request as draft
February 22, 2026 21:51
Author
|
Contributor
We don't have to be blocked by upstream and can just vendor the patch until this is merged. |
ju1m
marked this pull request as ready for review
February 23, 2026 14:32
Member
|
We can update to 1.0.2 release and merge this. the fix-vix patch can be removed, it was merged. I am not sure we need to update it to |
Contributor
|
If the alpha version is enough to fix #2227, I suggest we just merge this now and update it later. |
eljamm
previously approved these changes
Mar 31, 2026
…he first time
Hence the `bonfire.${flavour}.update.package` will only be rebuilt
when Bonfire's version has been updated.
> error: some outputs of '/nix/store/fjfaqq0997m0rlqr34r2wqnqwy0is6gb-bonfire-ember-update-1.0.3-alpha.10.drv' are not valid, so checking is not possible
ju1m
force-pushed
the
bonfire-update
branch
2 times, most recently
from
July 17, 2026 02:36
84206a6 to
3d02228
Compare
ju1m
changed the title
13 tasks
ju1m
force-pushed
the
bonfire-update
branch
3 times, most recently
from
July 21, 2026 01:16
a4e957d to
10b689a
Compare
ju1m
force-pushed
the
bonfire-update
branch
5 times, most recently
from
July 29, 2026 13:03
ba69dd5 to
367e2e3
Compare
ju1m
force-pushed
the
bonfire-update
branch
2 times, most recently
from
July 31, 2026 23:44
7fc1b56 to
36b2328
Compare
Author
|
Closing because |
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
ngipkgs.bonfire.updatefor correctly updating all bonfire flavours. This includes avoiding the shared-srcrace condition very likely with Bonfire.deps_nix: generateddeps.nixno longer ask forpkgsbut to be used withcallPackage.Fix BEAM help builders due toUsecallPackagenow used onmixNixDeps.callPackagesinstead.yarn.lockupstream, and propose a fix upstream maint/update(assets): fix yarn.lock bonfire-networks/bonfire_ui_common#10Checked
nom build -f. projects.Bonfire.tests.basicRequirements
Manually:
nix -L develop --impure --expr 'import <nixpkgs/maintainers/scripts/update.nix> { include-overlays = [ (final: prev: { inherit (import ./. {}) ngipkgs; }) ]; package = "ngipkgs.bonfire.update"; }'