Skip to content

Remove unused proto fields #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Remove unused proto fields #1067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
231 changes: 50 additions & 181 deletions api/grpc/mpi/v1/command.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

263 changes: 0 additions & 263 deletions api/grpc/mpi/v1/command.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 2 additions & 18 deletions api/grpc/mpi/v1/command.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,10 +358,6 @@ message APIDetails {
message NGINXAppProtectRuntimeInfo {
// NGINX App Protect Release
string release = 1;
// Attack signature version
string attack_signature_version = 2;
// Threat campaign version
string threat_campaign_version = 3;
}

// A set of actions that can be performed on an instance
Expand All @@ -371,16 +367,10 @@ message InstanceAction {}
message AgentConfig {
// Command server settings
CommandServer command = 1;
// Metrics server settings
MetricsServer metrics = 2;
// File server settings
FileServer file = 3;
// A series of key/value pairs to add more data to the NGINX Agent instance
repeated google.protobuf.Struct labels = 4;
repeated google.protobuf.Struct labels = 2;
// A list of features that the NGINX Agent has
repeated string features = 5;
// Message buffer size, maximum not acknowledged messages from the subscribe perspective
string message_buffer_size = 6;
repeated string features = 3;
}

// The command server settings, associated with messaging from an external source
Expand All @@ -392,9 +382,3 @@ message CommandServer {
// TLS configuration for secure communication
mpi.v1.TLSSettings tls = 3;
}

// The metrics settings associated with origins (sources) of the metrics and destinations (exporter)
message MetricsServer {}

// The file settings associated with file server for configurations
message FileServer {}
27 changes: 0 additions & 27 deletions docs/proto/protos.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
- [CreateConnectionRequest](#mpi-v1-CreateConnectionRequest)
- [CreateConnectionResponse](#mpi-v1-CreateConnectionResponse)
- [DataPlaneResponse](#mpi-v1-DataPlaneResponse)
- [FileServer](#mpi-v1-FileServer)
- [GetHTTPUpstreamServers](#mpi-v1-GetHTTPUpstreamServers)
- [GetStreamUpstreams](#mpi-v1-GetStreamUpstreams)
- [GetUpstreams](#mpi-v1-GetUpstreams)
Expand All @@ -67,7 +66,6 @@
- [InstanceMeta](#mpi-v1-InstanceMeta)
- [InstanceRuntime](#mpi-v1-InstanceRuntime)
- [ManagementPlaneRequest](#mpi-v1-ManagementPlaneRequest)
- [MetricsServer](#mpi-v1-MetricsServer)
- [NGINXAppProtectRuntimeInfo](#mpi-v1-NGINXAppProtectRuntimeInfo)
- [NGINXPlusAction](#mpi-v1-NGINXPlusAction)
- [NGINXPlusRuntimeInfo](#mpi-v1-NGINXPlusRuntimeInfo)
Expand Down Expand Up @@ -709,11 +707,8 @@ This contains a series of NGINX Agent configurations
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| command | [CommandServer](#mpi-v1-CommandServer) | | Command server settings |
| metrics | [MetricsServer](#mpi-v1-MetricsServer) | | Metrics server settings |
| file | [FileServer](#mpi-v1-FileServer) | | File server settings |
| labels | [google.protobuf.Struct](#google-protobuf-Struct) | repeated | A series of key/value pairs to add more data to the NGINX Agent instance |
| features | [string](#string) | repeated | A list of features that the NGINX Agent has |
| message_buffer_size | [string](#string) | | Message buffer size, maximum not acknowledged messages from the subscribe perspective |



Expand Down Expand Up @@ -843,16 +838,6 @@ Reports the status of an associated command. This may be in response to a Manage



<a name="mpi-v1-FileServer"></a>

### FileServer
The file settings associated with file server for configurations






<a name="mpi-v1-GetHTTPUpstreamServers"></a>

### GetHTTPUpstreamServers
Expand Down Expand Up @@ -1049,16 +1034,6 @@ A Management Plane request for information, triggers an associated rpc on the Da



<a name="mpi-v1-MetricsServer"></a>

### MetricsServer
The metrics settings associated with origins (sources) of the metrics and destinations (exporter)






<a name="mpi-v1-NGINXAppProtectRuntimeInfo"></a>

### NGINXAppProtectRuntimeInfo
Expand All @@ -1068,8 +1043,6 @@ A set of runtime NGINX App Protect settings
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| release | [string](#string) | | NGINX App Protect Release |
| attack_signature_version | [string](#string) | | Attack signature version |
| threat_campaign_version | [string](#string) | | Threat campaign version |



Expand Down
Loading