Skip to content

Reduce integration tests execution time #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

spencerugbo
Copy link

Proposed changes

This PR aims to use test suites to run multiple tests in a container in order to reduce overall execution time.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@spencerugbo spencerugbo self-assigned this Jul 16, 2025
@spencerugbo spencerugbo requested a review from a team as a code owner July 16, 2025 14:48
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 16, 2025
Copy link

github-actions bot commented Jul 16, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@spencerugbo
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Jul 17, 2025
"../../config/agent/nginx-config-with-grpc-client.conf")
defer teardownTest(t)

func (s *ConfigApplyTestSuite) TestGrpc_Test1_Reconnection() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func (s *ConfigApplyTestSuite) TestGrpc_Test1_Reconnection() {
func (s *MPITestSuite) TestGrpc_Test1_Reconnection() {

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the reconnection test in the MPI test suite causes the start up test to fail. I think its because of how the container is set up, the reconnection test works when expectNoErrorsInLogs is set to false, while the start up test works when it is set to true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants