-
Notifications
You must be signed in to change notification settings - Fork 95
Reduce integration tests execution time #1171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
"../../config/agent/nginx-config-with-grpc-client.conf") | ||
defer teardownTest(t) | ||
|
||
func (s *ConfigApplyTestSuite) TestGrpc_Test1_Reconnection() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func (s *ConfigApplyTestSuite) TestGrpc_Test1_Reconnection() { | |
func (s *MPITestSuite) TestGrpc_Test1_Reconnection() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the reconnection test in the MPI test suite causes the start up test to fail. I think its because of how the container is set up, the reconnection test works when expectNoErrorsInLogs is set to false, while the start up test works when it is set to true
Proposed changes
This PR aims to use test suites to run multiple tests in a container in order to reduce overall execution time.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)