Restart Subscribe on Connection Reset #1261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhurley
reviewed
Sep 11, 2025
| @@ -161,6 +170,7 @@ func (fms *FileManagerService) ConfigApply(ctx context.Context, | |||
|
|
|||
| fileErr := fms.executeFileActions(ctx) | |||
| if fileErr != nil { | |||
| fms.rollbackManifest = false | |||
There was a problem hiding this comment.
When does this boolean get reset to true?
There was a problem hiding this comment.
Good spot, I forgot adding now
sean-breen
approved these changes
Sep 11, 2025
craigell
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
FilePluginto update theFileManagerServiceconnection instead of creating a new one.UpdateManifestFileso if thepreviousManifestFilesmap is empty to use thecurrentFilesRollbackManifestbool to determine if the manifest needs to be rollback after a failed config applyChecklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)