Skip to content

Add new workflow to block direct module reference changes #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add new workflow to block direct module reference changes #863

wants to merge 7 commits into from

Conversation

lamATnginx
Copy link
Contributor

@lamATnginx lamATnginx commented Jul 21, 2025 •
edited by ADubhlaoich
Loading

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@lamATnginx lamATnginx self-assigned this Jul 21, 2025
@lamATnginx lamATnginx added the enhancement New feature or request label Jul 21, 2025
@github-actions github-actions bot added the tooling Back end, repository, Hugo, and all things not related to content label Jul 21, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 21, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/863/

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 21, 2025
View reviewed changes
@lamATnginx lamATnginx force-pushed the blocking-action branch 8 times, most recently from 189ac02 to cbc4404 Compare July 21, 2025 17:53
@lamATnginx
Copy link
Contributor Author

lamATnginx commented Jul 21, 2025 •
edited
Loading

TODO: add exemption rule

@lamATnginx lamATnginx changed the title Add new workflow to block direct module reference changes NGINX Plus - Module Ref - Add new workflow to block direct module reference changes Jul 21, 2025
@lamATnginx lamATnginx changed the title NGINX Plus - Module Ref - Add new workflow to block direct module reference changes Add new workflow to block direct module reference changes Jul 21, 2025
@lamATnginx lamATnginx changed the title Add new workflow to block direct module reference changes NGINX Plus - Module Ref - Add new workflow to block direct module reference changes Jul 21, 2025
@lamATnginx lamATnginx changed the title NGINX Plus - Module Ref - Add new workflow to block direct module reference changes Add new workflow to block direct module reference changes Jul 21, 2025
@lamATnginx lamATnginx marked this pull request as ready for review July 21, 2025 22:04
@lamATnginx lamATnginx requested a review from a team as a code owner July 21, 2025 22:04
@ADubhlaoich
Copy link
Contributor

Approved: please avoid linking to issues in closed, internal repositories.

If you want to create a logical link between an issue and a PR, you can do so from the sidebar of the issue.

TasoOneAsia
TasoOneAsia reviewed Jul 23, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TasoOneAsia TasoOneAsia TasoOneAsia left review comments

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@lamATnginx lamATnginx

Labels
enhancement New feature or request tooling Back end, repository, Hugo, and all things not related to content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lamATnginx @ADubhlaoich @TasoOneAsia