CP/DP Split: Support configuring NodePorts #3343
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Now that the control plane provisions the NGINX Service, users can't set specific NodePorts values. Solution: Allow users to specify NodePorts in the helm chart (globally) and in the NginxProxy resource.
github-actions
bot
added
documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3343 +/- ##
===================================================================
- Coverage 89.74% 86.66% -3.09%
===================================================================
Files 109 129 +20
Lines 11150 14837 +3687
Branches 50 62 +12
===================================================================
+ Hits 10007 12858 +2851
- Misses 1083 1831 +748
- Partials 60 148 +88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
salonichf5
reviewed
Apr 30, 2025
Comment on lines
+537
to
+542
| // NodePorts are the list of NodePorts to expose on the NGINX data plane service. | ||
| // Each NodePort MUST map to a Gateway listener port, otherwise it will be ignored. | ||
| // The default NodePort range enforced by Kubernetes is 30000-32767. | ||
| // | ||
| // +optional | ||
| NodePorts []NodePort `json:"nodePorts,omitempty"` |
There was a problem hiding this comment.
are we adding any sort of validation to enforce this range?
There was a problem hiding this comment.
No, because a user can change the range to be whatever they want. This is just the k8s default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Now that the control plane provisions the NGINX Service, users can't set specific NodePorts values.
Solution: Allow users to specify NodePorts in the helm chart (globally) and in the NginxProxy resource.
Testing: Verified that NodePorts are configurable and accessible.
Closes #3240
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.