Skip to content

Conversation

thresheek
Copy link
Member

Proposed changes

This PR fixes nginx binary startup as seen on the current image:

server  | >>> Starting nginx server...
server  | /usr/sbin/nginx: error while loading shared libraries: libpcre.so.3: cannot open shared object file: No such file or directory
server  | >>> Parameters:
server  | >>> Test case: handshake
server  | /usr/sbin/nginx: error while loading shared libraries: libpcre.so.3: cannot open shared object file: No such file or directory
server exited with code 127

Additionally, it adds a change to CI to trigger image rebuilds on workflow_dispatch events even if the commit id on the main nginx repo is the same as the currently built image.

It's a modern library and is available in the source image as opposed to
libpcre3 which is no longer in
martenseemann/quic-network-simulator-endpoint:latest.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes nginx startup issues by updating the Docker build to use the correct PCRE library version and enhances CI to allow manual image rebuilds even when the nginx commit hasn't changed.

  • Replaces deprecated libpcre3 packages with libpcre2-dev to resolve nginx binary startup errors
  • Adds workflow_dispatch trigger support to force CI builds regardless of commit ID comparison

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Dockerfile Updates PCRE library from libpcre3 to libpcre2-dev to fix nginx startup dependency issues
.github/workflows/docker-publish.yml Adds logic to trigger builds on manual workflow dispatch events

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@thresheek
Copy link
Member Author

Even with the image built with that fix, I'm still getting errors in interop tests as documented in #14 (comment) - not sure what could cause that.

@thresheek
Copy link
Member Author

I'm fairly sure the issue is in my environment somehow as the older image that was pasing the tests a couple days back on the online interop also exhibits the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant