fix: hide 'signup' button displayed on events and shop pages for logged-in users #1222 #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otification when accessing certain routes, such as `/events` and `/shop`, on the website. ### Solution To address this issue, I've modified the relevant components to utilize local storage for accessing the `isLoggedIn` status. Now, when a user is already logged in, the notification displayed on these routes appropriately reflects their authenticated status. ### Changes Made - Updated [ComponentName] to check the `isLoggedIn` status from local storage and adjust the notification accordingly. - Added conditional rendering logic to show different notifications based on the user's authentication status. - Updated tests to ensure the correct behavior of the modified components.
Currently, logged-in users are incorrectly shown a signup notification when accessing certain routes, such as /events and /shop, on the website. To address this issue, this commit modifies the relevant components to utilize local storage for accessing the isLoggedIn status. Now, when a user is already logged in, the notification displayed on these routes appropriately reflects their authenticated status. Changes Made: - Updated relevant components to check the isLoggedIn status from local storage and adjust the notification accordingly. - Added conditional rendering logic to show different notifications based on the user's authentication status. - Updated tests to ensure the correct behavior of the modified components.
…ed-in users ngoworldcommunity#1222 feat: added you will be notified div when user is logged in style: added style for above div in comingsoon.css
github-actions
bot
added
status: todo ⏳
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @ndmaratha, thank you for raising a pull request.
Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.
Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this pull request is of critical priority.
Give us a ⭐ to show some support
Happy OpenSource 🚀
|
This PR is fine, you can delete the other one or vice - versa |
tamalCodes
requested changes
Mar 11, 2024
tamalCodes
added
status: need changes 🚧
|
This pull request has been deployed to Vercel.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: added you will be notified div when user is logged in ,to solve the issue accessed the redux state user isloggedin and conditionaly rendered ui
style: added style for above div in comingsoon.css
closes #1222
👷🏻 Changes made
just conditionaly rendered the ui using redux state
📸 Screenshots