Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added port and network expose and removed react-scripts #1234

Closed
wants to merge 6 commits into from

Conversation

developerTested
Copy link

This PR will add feature which will allow user to pick custom port, hostname, add featured to remove ../.../.../ like import.

closes #1230

👷🏻 Changes made

  1. package.json
  2. vite.config.js
  3. frongend.md
  4. .env.example

@github-actions github-actions bot added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 💡 feature This generally contains addition/changes to features. labels Mar 3, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @developerTested, thank you for raising a pull request.

Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this pull request is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@tamalCodes
Copy link
Member

That's amazing features - since we now have introduced aliases - should we use it in at least files so that we know it works and can be done like this in the future ?

.env.example Show resolved Hide resolved
@tamalCodes tamalCodes added status: need changes 🚧 Changes have been requested for these PRs and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Mar 11, 2024
Copy link

This pull request has been deployed to Vercel.

Latest commit: cfab35f
✅ Preview: https://milan-ekh3ed9bt-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan/FijnZykVifAzoCPnywYWXStMAWfx

View Workflow Logs

developerTested and others added 2 commits March 30, 2024 15:16
@developerTested
Copy link
Author

New changes have been applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature This generally contains addition/changes to features. status: need changes 🚧 Changes have been requested for these PRs
Projects
Status: Merged/Discarded
Development

Successfully merging this pull request may close these issues.

Feature: Use .env file for Port, Network Expose and remove React Scripts
3 participants