Skip to content

build: remove bazel files #3406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .bazelignore

This file was deleted.

40 changes: 0 additions & 40 deletions .bazelrc

This file was deleted.

41 changes: 0 additions & 41 deletions .circleci/bazel.rc

This file was deleted.

77 changes: 0 additions & 77 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,9 @@ var_1: &cache_key yarn-cache-{{ checksum "yarn.lock" }}-0.14.1
var_2: &run_in_node
docker:
- image: circleci/node:14.17.0
var_3: &set_bazel_options
run:
command: sudo cp .circleci/bazel.rc /etc/bazel.bazelrc
var_5: &run_in_browser
docker:
- image: circleci/node:14.17.0-browsers
var_7: &bazel_cache_key yarn-bazel-cache-{{ checksum "master.txt" }}-0.14.1

commands:
write_master_hash:
Expand Down Expand Up @@ -73,29 +69,6 @@ jobs:
name: Run Affected Lint Checks
command: yarn nx affected:lint --base=$(cat ~/project/master.txt) --head=$CIRCLE_SHA1 --parallel=1

# Enforce some static analysis invariants.
# Note that generally, these should be checked only on the delta in each change,
# otherwise any change to the static analysis config requires updating all the
# code in the repo.
# Also analyzing everything makes the lint job slow.
lint-bazel:
<<: *run_in_node
steps:
- checkout
- *set_bazel_options
- restore_cache:
keys:
- *cache_key

# Run the Buildifier to check our Bazel rules for format issues.
- run: 'yarn bazel:format --mode=check ||
(echo "BUILD files not formatted. Please run ''yarn bazel:format --mode=fix''" ; exit 1)'

# Run the Buildifier to check our Bazel rules for lint issues.
# Note: The `--lint=warn` will auto fixe (re-write) the affected files.
- run: 'yarn bazel:format --lint=warn ||
(echo "BUILD files contain unresolved lint errors. Please fix manually the remaining errors." ; exit 1)'

test:
<<: *run_in_browser
steps:
Expand Down Expand Up @@ -168,50 +141,6 @@ jobs:
name: Run Affected Builds
command: yarn nx affected --target=build --base=$(cat ~/project/master.txt) --head=$CIRCLE_SHA1 --with-deps

build-bazel:
<<: *run_in_node
steps:
- checkout
- *set_bazel_options
- write_master_hash
- restore_cache:
keys:
- *bazel_cache_key
- *cache_key

# Build
- run: yarn
- run:
name: Build All Packages with Bazel
command: yarn bazel build //modules/...
# Store artifacts from build
- persist_to_workspace:
root: dist
paths:
- bin/*

update-master-hash:
<<: *run_in_node
steps:
- checkout
- *set_bazel_options
- write_master_hash
- restore_cache:
keys:
- *bazel_cache_key

# Build
- run: yarn
- run:
name: Build All Packages with Bazel
command: yarn bazel build //modules/...
- save_cache:
key: *bazel_cache_key
paths:
- ~/.cache/bazel_repository_cache
- ~/.cache/bazel_disk_cache
- node_modules

schematics-core-check:
<<: *run_in_browser
steps:
Expand Down Expand Up @@ -351,12 +280,6 @@ workflows:
filters:
branches:
only: master
# - update-master-hash:
# requires:
# - install
# filters:
# branches:
# only: master
- publish-stable:
requires:
- build
Expand Down
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ __build__/**
# Build Artifacts #
release
dist
bazel-out
bazel-bin
/node_modules/
lerna-debug.log
/lib/
Expand Down
11 changes: 0 additions & 11 deletions BUILD.bazel

This file was deleted.

83 changes: 0 additions & 83 deletions WORKSPACE

This file was deleted.

3 changes: 1 addition & 2 deletions build/tasks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ import { ncp } from 'ncp';
*/
export async function copySchematicsCore(config: Config) {
(ncp as any).limit = 1;
const filter = (name: string) =>
!name.endsWith('BUILD.bazel') && !name.endsWith('.eslintrc.json');
const filter = (name: string) => !name.endsWith('.eslintrc.json');

for (let pkg of util.getTopLevelPackages(config)) {
const packageJson = fs
Expand Down
6 changes: 0 additions & 6 deletions modules/BUILD

This file was deleted.

27 changes: 0 additions & 27 deletions modules/component-store/BUILD

This file was deleted.

31 changes: 0 additions & 31 deletions modules/component-store/migrations/BUILD

This file was deleted.

8 changes: 0 additions & 8 deletions modules/component-store/rollup.config.js

This file was deleted.

Loading