Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type safety of TranslateService and TranslatePipe #1529

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve type safety of TranslateService and TranslatePipe #1529

wants to merge 1 commit into from

Conversation

undsoft
Copy link

@undsoft undsoft commented Mar 7, 2025

Changes

  • TranslatePipe now explicitly accepts null and undefined and returns Translation. The code already guards against falsy values and specifying it explicitly helps when used with strictNullChecks in tsconfig. Otherwise, you may get a bunch of errors when an optional or nullable field is passed to the pipe.
  • Replaced any with unknown in InterpolationParams.
  • Fixes a test on non-English machines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@undsoft