fix(input-migration): enhance regexp to consider whitespaces when matching against temp… #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilirbeqirii
force-pushed
the
fix/signal-input-migration-chaining-operator-template
branch
from
6b2ddef to
e3ef9fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…late
Closes #397 (I also tried to work on the case mentioned on the issue, but am not sure I did it right. It would be helpful if we could have a more complete sample of non-working migration for the opened issue.)
When testing for matches in the template, please make sure we consider when the template code is not properly formatted and the interpolation expression has spaces on both sides.