Fix ISession.Refresh not updating initialized lazy properties #3697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValResnick
force-pushed
the
bugfix/#3622
branch
from
342122e to
ffc8a79
Compare
hazzik
reviewed
Sep 22, 2025
| private readonly string entityName; | ||
| private readonly System.Type mappedClass; | ||
|
|
||
| private readonly string[] originalUninitializedFields; |
There was a problem hiding this comment.
This seems to be same as uninitializedFieldsReadOnly
hazzik
reviewed
Sep 22, 2025
It is possible to update content of read-only set by updating underlying collection. It is expected that some tests will fail because they depend on that behavior.
hazzik
reviewed
Sep 22, 2025
| this.entityName = entityName; | ||
| this.mappedClass = mappedClass; | ||
| this.uninitializedFieldsReadOnly = uninitializedFields != null ? new ReadOnlySet<string>(uninitializedFields) : null; | ||
| this.uninitializedFieldsReadOnly = uninitializedFields != null ? new ReadOnlySet<string>(new HashSet<string>(uninitializedFields)) : null; |
There was a problem hiding this comment.
There was a bug that ReadOnlySet is not really read-only
It was possible to update content of read-only set by updating underlying collection.
Some tests were depend on that behavior.
There was a problem hiding this comment.
This is definitely an improvement, but I'd like to know more before I change it. So I added an extra variable.
hazzik
reviewed
Sep 22, 2025
| public ISet<string> GetUninitializedFields() | ||
| { | ||
| return uninitializedFieldsReadOnly ?? CollectionHelper.EmptySet<string>(); | ||
| return uninitializedFields ?? CollectionHelper.EmptySet<string>(); |
There was a problem hiding this comment.
Needed to return uninitializedFields, because some tests were depending on the of ReadOnlySet.
hazzik
changed the title
hazzik
changed the title
hazzik
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3622