Skip to content
This repository was archived by the owner on Apr 6, 2020. It is now read-only.

Update @toast-ui to v2.0 #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update @toast-ui to v2.0 #51

wants to merge 2 commits into from

Conversation

AruXc
Copy link

@AruXc AruXc commented Mar 25, 2020

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Update dependencies

@toast-ui v2.0 remove instance methods: setValue, getValue
so need to change this.editor.getValue to this.editor.getCurrentModeEditor().getValue()
just a simple update, need optimize this.


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant