Skip to content

Update to .NET 8 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jryckman merged 2 commits into from
Dec 1, 2025
Merged

Update to .NET 8 #102

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8adb32
build with .net 8
Nov 18, 2025
e65536b
use same global.json as asw
Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
</PropertyGroup>

<PropertyGroup>
<NILibraryTargetFramework>net6.0</NILibraryTargetFramework>
<NIExecutableTargetFramework>net6.0</NIExecutableTargetFramework>
<NILibraryTargetFramework>net8.0</NILibraryTargetFramework>
<NIExecutableTargetFramework>net8.0</NIExecutableTargetFramework>
<NIAnalyzersTargetFramework>netstandard2.0</NIAnalyzersTargetFramework>

<Nullable>enable</Nullable>
Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "6.0.400",
"version": "8.0.400",
"rollForward": "latestFeature"
}
}
1 change: 0 additions & 1 deletion nuget.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@
<add key="automatic" value="True" />
</packageRestore>
<packageSources>
<add key="NuGet" value="https://www.nuget.org/api/v2/" />
Copy link
Copy Markdown
Contributor Author

@yaqian256 yaqian256 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: Removed this to avoid warning NU1507: There are 2 package sources defined in your configuration. When using central package management, please
map your package sources with package source mapping (https://aka.ms/nuget-package-source-mapping) or specify a single package source. The following sources are defined: NuGet, nuget.org

Copy link
Copy Markdown
Collaborator

@nick-beer nick-beer Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this change? I think it would be better to add a <clear /> here.

</packageSources>
</configuration>
2 changes: 1 addition & 1 deletion tests/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<Import Project="..\Directory.Build.props" />

<PropertyGroup>
<NILibraryTargetFramework>net6.0</NILibraryTargetFramework>
<NILibraryTargetFramework>net8.0</NILibraryTargetFramework>
<NIAnalyzersTargetFramework>net48</NIAnalyzersTargetFramework>
</PropertyGroup>

Expand Down