Skip to content

Add NVIDIA ASR NIM transcription provider#34

Open
absalonCRC wants to merge 1 commit into
nibzard:mainfrom
absalonCRC:absaloncrc/add-nvidia-nim-provider
Open

Add NVIDIA ASR NIM transcription provider#34
absalonCRC wants to merge 1 commit into
nibzard:mainfrom
absalonCRC:absaloncrc/add-nvidia-nim-provider

Conversation

@absalonCRC
Copy link
Copy Markdown

Summary

  • Add an NVIDIA ASR NIM provider wired as --api nvidia
  • Use environment-driven NVIDIA_NIM_API_KEY, NVIDIA_NIM_BASE_URL, and NVIDIA_NIM_MODEL configuration
  • Document the new provider in the README and add focused stdlib tests for configuration, request construction, and validation

Test plan

  • PYTHONPATH=src python3 -m unittest discover -s tests
  • PYTHONPATH=src python3 -m py_compile src/sapat/script.py src/sapat/transcription/nvidia.py tests/test_nvidia_transcription.py

@absalonCRC
Copy link
Copy Markdown
Author

absalonCRC commented May 21, 2026

Status update for review:

  • This companion PR supports Run NVIDIA ASR NIM with Sapat daytonaio/content#233 for the NVIDIA ASR NIM / Parakeet Sapat guide.
  • Fresh local revalidation on 2026-05-21T11:34+02:00 passed:
    • PYTHONPATH=src python3 -m unittest discover -s tests -> 3 tests passed
    • PYTHONPATH=src python3 -m py_compile src/sapat/script.py src/sapat/transcription/nvidia.py tests/test_nvidia_transcription.py
  • The current GitHub status is only waiting on external Continue agent checks; I do not see a failing test/check result.
  • Maintainer edits are enabled and the implementation uses environment-based config only, with no secrets committed.

@absalonCRC
Copy link
Copy Markdown
Author

Hi @nibzard, I tried to request review through GitHub but do not have permission to use reviewer assignment on this upstream PR. Could you route this for review when available?

This is the companion implementation for daytonaio/content#233. Local validation passed with unittest discovery and py_compile, maintainer edits are enabled, and the implementation keeps NVIDIA config in environment variables only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant