Skip to content

Add keyword: "Hasher" #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickbabcock merged 1 commit into from
Nov 8, 2020
Merged

Add keyword: "Hasher" #37

nickbabcock merged 1 commit into from
Nov 8, 2020

Conversation

@tkaitchuck
Copy link
Contributor

@tkaitchuck tkaitchuck commented Nov 7, 2020

@nickbabcock
Copy link
Owner

nickbabcock commented Nov 7, 2020

Excellent, I appreciate the initiative you're spearheading. Is there consensus if hasher should replace the hash keyword or if hasher should be added in addition.

@tkaitchuck
Copy link
Contributor Author

tkaitchuck commented Nov 8, 2020

@nickbabcock The goal is to get things that implement Hasher trait to have that keyword. Hash is a more general keyword and seems to have a lot of other stuff in it. There is no problem having both attached to a given crate other than the crates.io limit of 5 keywords per crate.

@nickbabcock nickbabcock merged commit 6025681 into nickbabcock:master Nov 8, 2020
@nickbabcock
Copy link
Owner

nickbabcock commented Nov 8, 2020

Ah yup, thanks for clarifying. This has been released as part of 0.6.1.

@tkaitchuck tkaitchuck deleted the patch-1 branch November 8, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tkaitchuck @nickbabcock