Add helper-level rev5 vs rev6 validator, correctness-first monte_carlo_super_bs_eirp_dist_rev7, and rev15 integration#13
Open
nicklasorte wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
interp1('spline')with custom PP evaluation, so a correctness-first path and diagnostics are required.Description
validate_monte_carlo_super_bs_eirp_dist_rev5_rev6.m, a helper-level comparator that reconstructs the exact helper-call inputs, runs bothrev5andrev6, reports shapes, max/mean absolute and relative diffs, worst-case indices, and clustering near endpoints/breakpoints/clamps, and fails closed on tight thresholds.monte_carlo_super_bs_eirp_dist_rev7.mas a correctness-first helper that preservesrev5per-rowinterp1(...,'spline')semantics, adds shape/length assertions and optionalDEBUG_CHECKS, clamps queries, and avoids the manual PP evaluation strategy used inrev6.subchunk_agg_check_maxazi_rev15.mby cloning therev11aggregation/RNG/chunking flow and replacing only the EIRP helper invocation withmonte_carlo_super_bs_eirp_dist_rev7, preserving RNG and chunking behavior.validate_subchunk_agg_check_maxazi_rev11_rev15_statistical.mto run end-to-end rev11 vs rev15 comparisons on identical inputs, measure runtimes, compute summary and upper-tail metrics (mean/std/min/max/median/p90/p95/p99), and enforce fail-closed thresholds.Testing
must_exist(...)guards and return structuredresultsobjects for automated gating; those functions are in place for runtime validation. — code-paths added (no runtime execution).octave/MATLAB is not available, so helper-level and end-to-end numeric tests were not run here; the validation scripts are written to be run in a MATLAB/Octave environment and will fail-closed if drift thresholds are exceeded. — runtime check not executed (environment limitation).Codex Task