Harden static analysis checks - #317
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nicklemmon
force-pushed
the
type-safety-hardening
branch
from
September 4, 2026 22:15
a3c0e36 to
2af5820
Compare
nicklemmon
changed the title
nicklemmon
commented
Sep 5, 2026
| stats: { | ||
| attack: number | ||
| } | ||
| // TODO: Can this be removed? |
Owner
Author
There was a problem hiding this comment.
Hmm, why did I leave this comment.
Comment on lines
+14
to
+17
| align?: 'left' | 'right' | undefined | ||
| artwork?: string | undefined | ||
| status?: 'disabled' | 'in-play' | 'idle' | undefined | ||
| orientation?: 'face-up' | 'face-down' | undefined |
Owner
Author
There was a problem hiding this comment.
Having both optional and undefined at the same time doesn't seem ideal
| onCreate={(formData) => { | ||
| send({ | ||
| type: 'CREATE_CHARACTER', | ||
| // @ts-expect-error |
Comment on lines
17
to
23
| @@ -23,7 +29,6 @@ | |||
| "@xstate/react": "6.1.0", | |||
Owner
Author
There was a problem hiding this comment.
Why get rid of concurrently? Isn't this faster?
|
|
||
| /** Overlays the avatar and applies a flash when healing */ | ||
| function HealingFlash({ onAnimationComplete }: { onAnimationComplete?: () => void }) { | ||
| function HealingFlash({ onAnimationComplete }: { onAnimationComplete?: (() => void) | undefined }) { |
Owner
Author
There was a problem hiding this comment.
Again with the optional + undefined - can we not do that? One or the other should be fine. It makes things much more complex.
Comment on lines
+22
to
+24
| isStacked?: boolean | undefined | ||
| onClick?: (() => void) | undefined | ||
| className?: string | undefined |
Owner
Author
There was a problem hiding this comment.
Again, the optional and undefined typing is not great.
Comment on lines
+28
to
+35
| const characterClass = formData.get('characterClass') | ||
| const characterName = formData.get('characterName') | ||
| const characterPortrait = formData.get('characterPortrait') | ||
| if ( | ||
| typeof characterClass !== 'string' || | ||
| typeof characterName !== 'string' || | ||
| typeof characterPortrait !== 'string' | ||
| ) |
Owner
Author
There was a problem hiding this comment.
Do we have zod available to validate these things? Can we add it?
Should that validation be part of the state machine?
| return Math.floor(Math.random() * maxExclusive) | ||
| } | ||
|
|
||
| pick<T>(xs: readonly T[]): T { |
Owner
Author
There was a problem hiding this comment.
This method is defined twice.
And each method could use some JSDoc descriptions.
nicklemmon
force-pushed
the
type-safety-hardening
branch
from
September 5, 2026 11:50
7b75379 to
ab9d69b
Compare
requireAsset was copy-pasted identically across cards.ts, item.ts, and monsters.ts; moved it into vite.ts alongside the other glob helpers. The css[key] ?? '' workaround for noUncheckedIndexedAccess was also repeated ad hoc across ~10 components; added cx()/cssClass() in helpers/css.ts to centralize the safe lookup. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GzLmUWBV6CUEVjoDuTZkAF
nicklemmon
force-pushed
the
type-safety-hardening
branch
from
September 5, 2026 11:54
b7caefb to
cc93236
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation