Add reusable card finishes and interactive demo - #321
Open
nicklemmon wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds reusable decorative finishes to playing cards and an interactive comparison page at
/card-finishes, linked from the title screen. Cards can opt into etched foil (30%), prismatic (60%), gilded (50%), or ember (85%) through thefinishprop, with optional strength and animation overrides.The demo shows the original card alongside all four finishes, with artwork selection, independent strength sliders, reset, and animation controls. Foil keeps its texture anchored while light moves; embers have varied positions, sizes, timing, and drift. Effects use CSS layers, preserve readable card text, and respect reduced motion.
Validation: repository formatting, typechecking, and lint scripts passed; all 138 tests passed. Browser checks covered independent strength changes/reset, anchored foil, ember pause/reduced motion, and mobile overflow. Browser tests were run outside the sandbox to allow their local server to bind a port.