Fix issue where parseType helper didn't handle qualified types like Foo.Bar #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
commented
Dec 13, 2023
| let input = """ | ||
| extension SectionContainer: ContentProviding where Section: ContentProviding { | ||
| @_disfavoredOverload | ||
| public var content: Section.Content { |
There was a problem hiding this comment.
Before the fix in this PR this example was incorrectly handled as a stored property, causing it to be updated incorrectly to @_disfavoredOverload public var content: Section.Content { ... }.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1597 +/- ##
===========================================
- Coverage 95.11% 95.10% -0.01%
===========================================
Files 20 20
Lines 22112 22122 +10
===========================================
+ Hits 21032 21040 +8
- Misses 1080 1082 +2 ☔ View full report in Codecov by Sentry. |
calda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
parseTypehelper didn't handle qualified types likeFoo.BarorFoo.Bar.Baaz.This could cause the
isStoredProperty(atIntroducerIndex:)helper to return the incorrect result for properties with a qualified type name, like in the example added as a test case.