Remove runtime stdlib dependency from pre-built binary targeting Linux #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the pre-built binary targeting Linux links Swift stdlib and core libraries dynamically. Unlike darwin platforms, Swift does not guarantee ABI stability on Linux, so the pre-built binary must be run with exactly the same version of Swift stdlib and core libraries that it was built with on GitHub Actions. And also the shared libraries can be installed in various locations, so users usually need to set `LD_LIBRARY_PATH`. However, asking users to do the above works only for power users. Reducing the runtime dependencies makes it usable for more users.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1605 +/- ##
==========================================
- Coverage 95.25% 95.22% -0.03%
==========================================
Files 17 17
Lines 20751 20751
==========================================
- Hits 19766 19761 -5
- Misses 985 990 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the pre-built binary targeting Linux links Swift stdlib and core libraries dynamically. Unlike darwin platforms, Swift does not guarantee ABI stability on Linux, so the pre-built binary must be run with exactly the same version of Swift stdlib and core libraries that it was built with on GitHub Actions. And also the shared libraries can be installed in various locations, so users usually need to set
LD_LIBRARY_PATH.However, asking users to do the above works only for power users. Reducing the runtime dependencies makes it usable for more users.
The only downside of static-linkage is the significant binary-size (9.4M -> 57M). But IMHO a larger binary is better than the one hard to run. The most of huge binary size came from unused ICU data and Foundation, so we can expect it will be much smaller after adopting https://github.com/apple/swift-foundation and LTO integration in SwiftPM (upcoming in 5.10)