Add type hints, function docstrings and comments#81
Open
evanhunter wants to merge 2 commits intonickw444:masterfrom
Open
Add type hints, function docstrings and comments#81evanhunter wants to merge 2 commits intonickw444:masterfrom
evanhunter wants to merge 2 commits intonickw444:masterfrom
Conversation
on_state_change() caused an error due to incorrect number of arguments
Does not change functionality Adds type hints for function args, returns and variables where missing
Owner
|
@evanhunter do you mind rebasing this on top of the most recent changes? Would it be possible for you to introduce additional linting steps to avoid further regression over time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge #79 first
Add type hints, function docstrings and comments
Does not change functionality
Adds type hints for function args, returns and variables where missing