Improved GUI #2
Improved GUI #2
Conversation
| JButton standardGameButton = new JButton(Gui.getMessages().getString("standard")); | ||
| JButton duelGameButton = new JButton(Gui.getMessages().getString("duel")); | ||
| JButton gameInfoButton = new JButton(Gui.getMessages().getString("help")); | ||
| //Construct new Components |
There was a problem hiding this comment.
You can notice that we use resource bundles instead of typing strings for the names of JLabels and other text field components. The reason we use the resource bundle (e.x. Gui.getMessages().getString("standard") is to use multi-linguar in the program, in other words when a user has the Greek language he/she won't be able to see the text in Greek. So I suggest that you remove any hard coded string you typed and use the strings of the resource bundle. You can check which Strings are available in the bundle in the MessageBundle_en_US.properties file or in any other .properties file.
| @@ -1,3 +1,4 @@ | |||
| import javax.management.StandardEmitterMBean; | |||
There was a problem hiding this comment.
This library is not used anyore in the code (Remove it if you don't need it)
| //End | ||
|
|
||
|
|
||
| title.setText("<html><font color=black size=45><b>Memory Game</b></html>"); |
There was a problem hiding this comment.
Don't use HTML code just for one text-label, try and replace this with normal java code
| gameInfoButton.setBackground(new Color(59, 89, 182)); | ||
| gameInfoButton.setForeground(Color.WHITE); | ||
| gameInfoButton.setFocusPainted(false); | ||
| gameInfoButton.setFont(new Font("Tahoma", Font.BOLD, 12)); |
There was a problem hiding this comment.
Try and make one Font instance-Object and assign it to the components that use the same Font instead of making new ones each time (ensures code readability)
| @@ -44,10 +76,12 @@ | |||
|
|
|||
| GridLayout grid = new GridLayout(2, 0, 10, 20); | |||
|
|
|||
| gameSelectionPanel.setLayout(grid); | |||
| //Added Absolute Positioning | |||
| gameSelectionPanel.setLayout(null); | |||
There was a problem hiding this comment.
The whole layout seems that is not justified in the middle. Try and make the layout and text be in the middle of the screen.
Also please notice that the screen is now too empty, try and make the components a bit bigger
There was a problem hiding this comment.
@nikopetr
This is very weird because when I run it on my side I get this
There was a problem hiding this comment.
I guess you should test it with different screen sizes as well. Also, make sure to fix the other things mentioned.
So I just changed the Main Menu and just wanted to see if this is what you're looking for.