sem: proper error propagation for set construction #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Refactor/fix set construction analysis such that: * `nkRange` nodes are properly analyzed after macro expansion * errors within set constructions are propagated properly Details ======= Only `semSetConstr` is modified: * use `shallowCopy` instead of creating a new node (no seq resizing, keeps the persistent node flags) * always re-analyze `nkRange` nodes (they were previously never typed) * guard against ill-formed `nkRange` AST * don't modify the input AST * replace `localReport` with using `nkError` * propagate `nkError`
zerbina
added
bug
saem
approved these changes
Apr 23, 2024
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor/fix set construction analysis such that:
nkRangenodes are properly analyzed after macro expansionDetails
Only
semSetConstris modified:shallowCopyinstead of creating a new node (no sequenceresizing, keeps the persistent node flags)
nkRangenodes (they were previously never typed)nkRangeAST (could previously crash thecompiler)
localReportwith usingnkErrornkError