Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: add missing boolean rules #124

Merged
merged 2 commits into from
Mar 9, 2025

Conversation

zerbina
Copy link
Collaborator

@zerbina zerbina commented Mar 8, 2025

Summary

  • add reduction rules for Ident("true") and Ident("false")
  • add reduction and type deduction rules for not

zerbina added 2 commits March 8, 2025 15:05
`Ident("true")` and `Ident("false")` are not considered values.
Both the reduction and type deduction rules were missing.
@zerbina zerbina added the bug Something isn't working label Mar 8, 2025
@zerbina
Copy link
Collaborator Author

zerbina commented Mar 8, 2025

It's also possible for Ident("true") and Ident("false") to be considered values, in which case True and False would become defs rather than meta-language values / type constructors.

Intuitively, I would say that the current approach is better in the short term, though it might have to be revisited in the longer term.

@saem saem merged commit 8767f00 into nim-works:main Mar 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants