Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing all results in a cell | Removed possible unintended texts | Corrected typos | Report broken hyperlinks in binder (see below) #36

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

issa-garcia
Copy link

-Added a small part to explain how to print results of not only the last line of code inside a cell (lines of .Rmd 75-81)
-Removed line 117 (a possible unintended text)
-Removed line 195 (a possible unintended text)
-Corrected a typo in line 277.
-Issue: On line 277 {doc}truthiness hyperlink is not working in binder.
--Removed line 697 (a possible unintended text)
--Issue: On line 747 {doc}length_one_tuples hyperlink is not working in binder.
-Modified line 876 to show results of 2nd line of code in the cell
//Stopped at end of section "Range", I will continue in 1 hour

…Corrected typos | Report broken hyperlinks in binder (see description)
Fixed a typo on line 1071. Actual number in the text should have been 100.
Fixed typo in line 43: "here" into "hear"

P.S. Atom is apparently going to be archived in December 15, 2022 (see Atom website for more info: https://github.blog/2022-06-08-sunsetting-atom/). You might want to change the example mentioned into other code editors or redirect to your "choosing an editor" website (https://textbook.nipraxis.org/choosing_editor.html).
Atom mentions on their near-future archiving notice (https://github.blog/2022-06-08-sunsetting-atom/) this option which seems like a VS code online version from Github (https://github.com/features/codespaces). It might be good to have information about it on this website. Let me know if you would like me to write a small section about it.
Copy link
Collaborator

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much, just three requests to re-add hidden lines that have disappeared.

@@ -107,7 +114,6 @@ The `%` operator on numbers gives you the remainder of integer division
5.0 % 2.0
```

(true-and-false)=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed? (please re-add)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In binder they look like this. I was not sure if they were a mistake.

image

But now I see on the website version they look OK.

image

Should I re-add still? Should I look for a way the they do not look like that in Binder? I now assume they are there for a reason, do you know what is the function of those lines?

@@ -186,7 +192,6 @@ different from MATLAB, which uses `~=`:
a != 1
```

(comparison-operators)=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@@ -269,7 +274,7 @@ print('not True:', not True)
print('not False:', not False)
```

In fact, the logical operators will first force their arguments to be True or False before they give their answer. So, in the case of `and` or `or`, they force force their left and right arguents to be `bool` values, before they calculate the answer. So, in fact, you can use things other than exact True and False on either side of the `and` or `or`, as long as applying `bool(value)` to the thing to the left and right will produce a True or False value. See {doc}`truthiness` for more detail.
In fact, the logical operators will first force their arguments to be True or False before they give their answer. So, in the case of `and` or `or`, they force their left and right arguents to be `bool` values, before they calculate the answer. So, in fact, you can use things other than exact True and False on either side of the `and` or `or`, as long as applying `bool(value)` to the thing to the left and right will produce a True or False value. See {doc}`truthiness` for more detail.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In fact, the logical operators will first force their arguments to be True or False before they give their answer. So, in the case of `and` or `or`, they force their left and right arguents to be `bool` values, before they calculate the answer. So, in fact, you can use things other than exact True and False on either side of the `and` or `or`, as long as applying `bool(value)` to the thing to the left and right will produce a True or False value. See {doc}`truthiness` for more detail.
In fact, the logical operators will first force their arguments to be True or False before they give their answer. So, in the case of `and` or `or`, they force their left and right arguents to be `bool` values, before they calculate the answer. So, in fact, you can use things other than exact `True` and `False` on either side of the `and` or `or`, as long as applying `bool(value)` to the thing to the left and right will produce a True or False value. See {doc}`truthiness` for more detail.

@@ -689,7 +694,6 @@ you a reversed copy of the list:
my_list[::-1]
```

(tuples)=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Copy link
Author

@issa-garcia issa-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed the website in detail. GitHub Codespaces is VS code running on cloud services with a cost. So I do not think it is a good idea to add. Please disregard the commit about adding GitHub Codespaces as an editor.

@@ -76,6 +76,7 @@ to PyCharm users).
* [Sublime text](https://www.sublimetext.com)
* [Emacs](https://emacs.org)
* [Spyder](https://www.spyder-ide.org)
* [GitHub Codespaces](https://github.com/features/codespaces)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [GitHub Codespaces](https://github.com/features/codespaces)

@matthew-brett
Copy link
Contributor

I just reviewed the website in detail. GitHub Codespaces is VS code running on cloud services with a cost. So I do not think it is a good idea to add. Please disregard the commit about adding GitHub Codespaces as an editor.

Yes - I agree - I don't think this could replace the use of a text editor working on your own computer.

added some minor additional missing information that I think would be useful for the reader
stopped at line 176; will continue later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants