[WIP] Task generation #1
Conversation
There was a problem hiding this comment.
These are both listed as [WIP], which indicates that they are not ready for review or consideration.
Is that what was intended?
Additonally, the commit message of "do setup" is not sufficiently descriptive to describe the changes made in the patch. Commit messages should describe the patch.
The second commit message should also describe the work that was done to generate these files, including the command line option that was run to generate the results.
Yes. The pull request, at the moment, is just to let people know where we are at / what we are working on. Work still needs to be done (e.g.
The commit messages are also apart of the work we need to do; the messages are not intended to be final. The commits are probably going to broken apart (e.g. a separate commit for the generation of the files) and changed as we work though it. We will be sure to describe them well.
We added tools/README.md for that documentation purpose. As with the other documentation it is not very thorough at the moment. Some of our TODOs
|
nipype/interfaces/slicer/generate_classes.py will be used as a base with the goal of auto generating pydra tasks
- reorder imports - add xml_dir parameter - add dom_from_xml function - rename grab_xml to dom_from_binary - add command line parameter: xml directory
- add output_dir parameter - directory will be created if it doesn't exist - add command line parameter: output_dir output_dir is first so binary sources can make use of it
use .format() over f string if a keyword would be more descriptive
this removes the need to keep format in mind when generating the code
documents tools/ contents and how to use generate_tasks.py more documentation needed Co-authored-by: Michal Brzus <[email protected]> Co-authored-by: Chase Johnson <[email protected]>
some quick fixes to demonstrate some of the changes needed Co-authored-by: Michal Brzus <[email protected]> Co-authored-by: Chase Johnson <[email protected]>
Co-authored-by: Michal Brzus <[email protected]> Co-authored-by: Chase Johnson <[email protected]>
|
@satra Do you know of someone interested in taking over this work? We have not been able to get back at it recently. |
|
@hjmjohnson - I will take a look! |
|
A new PR continuing this work was created (Pull Request #2). It was put in a new pull request because this PR#1 came from unknown repository to which I do not have access. |
Co-authored-by: Michal Brzus [email protected]
Co-authored-by: Chase Johnson [email protected]
Description
This PR includes the work that was completed during ohbm brainhack 2020
Status
Work in progress