-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load kernel modules #524
Open
terlar
wants to merge
2
commits into
nix-community:main
Choose a base branch
from
terlar:load-kernel-modules
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−0
Open
Load kernel modules #524
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unchanged files with check annotations Beta
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
out ulong defaultEnvironmentVariableCount | ||
); | ||
byte** envv; | ||
ulong envc; | ||
CheckResult( | ||
WslGetDistributionConfiguration( |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namespace Launcher.WSL; | ||
public static partial class WslApiLoader { | ||
public static void WslLaunch( | ||
string distributionName, | ||
string? command, | ||
bool useCurrentWorkingDirectory, |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
string distributionName, | ||
string command, | ||
bool useCurrentWorkingDirectory, | ||
out uint exitCode, | ||
bool noStderr = false | ||
) { | ||
using SafeFileHandle realStdin = new(GetStdHandle(STD_HANDLE.STD_INPUT_HANDLE), false); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<data name="Error_NotInstalled" xml:space="preserve"> | ||
<value>{0} ist nicht installiert!</value> | ||
</data> | ||
<data name="Version_Launcher" xml:space="preserve"> | ||
<value>Launcher: {0}</value> | ||
</data> | ||
<data name="Version_Module" xml:space="preserve"> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Flags] | ||
[SuppressMessage("Naming", "CA1711")] // Flags suffix is appropriate | ||
public enum WslDistributionFlags { | ||
None = 0x0, | ||
EnableInterop = 0x1, | ||
AppendNtPath = 0x2, | ||
EnableDriveMounting = 0x4 | ||
} | ||
public const WslDistributionFlags WslDistributionFlagsValid = | ||
WslDistributionFlags.EnableInterop | | ||
WslDistributionFlags.AppendNtPath | | ||
WslDistributionFlags.EnableDriveMounting; | ||
public const WslDistributionFlags WslDistributionFlagsDefault = | ||
WslDistributionFlags.EnableInterop | | ||
WslDistributionFlags.AppendNtPath | | ||
WslDistributionFlags.EnableDriveMounting; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namespace Launcher; | ||
public static class ExceptionContext { | ||
public static void AddContext(this Exception e, string context) => throw new ContextualizedException(context, e); | ||
public static void AddIfThrown(Action action, string context) { | ||
try { |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namespace Launcher.WSL; | ||
public static partial class WslApiLoader { | ||
public static void WslConfigureDistribution( | ||
string distributionName, | ||
ulong defaultUid, | ||
WslDistributionFlags wslDistributionFlags |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we reuse
boot.kernelModules
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is gated behind
boot.kernel.enable
which we don't want to enable.Another option is to have something like a boolean
wsl.loadKernelModules
. That will write the file with the value based onboot.kernelModules
. What do you prefer?