Skip to content

Allow setting wsl default user in the default nix config of the generated tarball #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jbury
Copy link

@jbury jbury commented Apr 12, 2025

The docs actually already say this is possible 🤷

jbury added 2 commits April 11, 2025 14:43
Partially to fix the problem (since Get-Command _should_ always work, and partially just to get more information about what specific wsl executible is being used in each case, on the off chance we sometimes use the wrong one.
@jbury
Copy link
Author

jbury commented Apr 13, 2025

I'm not particularly knowledgeable on wsl - my initial "guess" as to what might be happening was that some agents might be loaded with an ancient/unpatched wsl.exe in one path, and another up-to-date one in another path, and inconsistently pick which to actually use for some reason.

My change to stop calling wsl --version, and instead just use Get-Command probably "fixes" the problem that's been making the pipelines fail sporadically, but not because Get-Command is actually a better command to use here. It's just because we're no longer calling wsl --version at all, which seems to have been most of the problem. Why? Not a damn clue. Unless there's some hidden configuration around the runners or their setup I'm not seeing in the .github dir, I'm not sure what more we can even do to investigate this specific bug.

I'm leaving Get-Command in regardless, because it's at least slightly more information about what we're running than removing the line entirely, but I'm happy to remove it entirely if folks want.

@jbury
Copy link
Author

jbury commented Apr 23, 2025

I'm adding the wsl --version call back in, mostly because I'm curious if it's got any more useful information for us.

@jbury
Copy link
Author

jbury commented Apr 27, 2025

@nzbr I'm not loving the flakiness of the pipeline tests even though I'm positive my change has nothing to do with the failures, but I don't think I should keep experimenting with fixes on this PR.

I think it's worth keeping the Get-Command invocation in the Setup WSL job just so we can see if we ever end up hitting a wsl binary at a path other than C:\Windows\system32\wsl.exe - but I think it'd be worth it to just split any further work on the pipeline stability into a new PR, and probably track it in an Issue.

Thoughts? Any feedback on the original change here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant