fix(fetchers/git): dont fetch shallow by default #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90-008
force-pushed
the
git-fetcher-no-shallow
branch
from
cc15e58 to
3779210
Compare
|
I don't quite get it. In which situation would we not want to fetch shallow and why? |
|
it's because cargo doesn't specify the ref and only the revision iirc? and shallow only fetches the default branch so if the rev is on another branch it complains (we could just enable this for cargo only i just didn't think of that at the time) |
|
I think shallow cloning only by revision should work fine. Could you check again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #1037
it seems like since 2.20 shallow works properly (?) and this causes the rev to not be found.