Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply clippy::pedantic lints & improve CI #62

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bryango
Copy link
Collaborator

@bryango bryango commented Jan 27, 2025

This PR provides:

  • more thorough testing via github actions, and
  • some functionally trivial changes to improve the rust codebase, guided by the clippy::pedantic lints.

It would be easy to review commit by commit:

  1. the first commit sets up the clippy lints and github actions CI, while
  2. the second commit actually applies the clippy lints by cargo clippy --fix with some manual tweaks for readability.
  3. (new) the third commit drops magic nix cache in CI as it's near its end of life: https://determinate.systems/posts/magic-nix-cache-free-tier-eol/

After this, I think we have collected enough minor fixes to justify a new bugfix release, as is hoped for in #60 (comment) 😆

@bryango bryango marked this pull request as ready for review January 27, 2025 08:27
@bryango bryango requested review from makefu and Artturin January 27, 2025 08:31
@bryango
Copy link
Collaborator Author

bryango commented Jan 28, 2025

Update: added a third commit which drops magic nix cache in CI as it's near its end of life: https://determinate.systems/posts/magic-nix-cache-free-tier-eol/

@bryango
Copy link
Collaborator Author

bryango commented Jan 30, 2025

These are mostly trivial changes so I will be merging this soon, if there are no objections! 👀 @makefu @Artturin I will also make a bugfix release afterward for #60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant