Skip package sets that may not exist in older nixpkgs revisions. #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meaning indexes produced at the same nixpkgs commit always result in the database with identical checksum. This resulted in non-toplevel attrs being absent from the index but they are not useful for use cases like "comma", command not found handlers.
When running nix-index on old nixpkgs, scopes like rPackages are missing, so instead of exiting with an error, this change issues an error to stderr and skips such package set. Motivation: while it's possible to use an older version of nix-index to create the index for older nixpkgs, newer nix-index is much more performant so it's useful to be able to use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running nix-index on old nixpkgs, scopes like rPackages are missing, so instead of exiting with an error, this change issues an error to stderr and skips such package set.
Motivation: while it's possible to use an older version of nix-index to create the index for older nixpkgs, newer nix-index is much more performant so it's useful to be able to use it.