Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrappers: define pkgs default within type declaration #2406

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

MattSturgeon
Copy link
Member

@MattSturgeon MattSturgeon commented Oct 10, 2024

  • wrappers: move programs.nixvim declaration to _shared.nix
  • wrappers: define pkgs default within type declaration

The first commit refactors the programs.nixvim option declaration so that it can be centralised to wrappers/_shared.nix, the second commit then moves the nixpkgs.pkgs = pkgs definition into the evalNixvim call.

This means nixpkgs.pkgs is defined in a module that is considered part of programs.nixvim's type. Config definitions are not part of the type, and therefore are not part of type.getSubModules or type.getSubOptions.

Fixes #2378

@MattSturgeon
Copy link
Member Author

@Mergifyio queue

Copy link
Contributor

mergify bot commented Oct 11, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 5cd8c9c

Copy link
Contributor

mergify bot commented Oct 11, 2024

This pull request, with head sha 5cd8c9cf3104027b42ffe531fb68463ecb08ebc9, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha 5cd8c9cf3104027b42ffe531fb68463ecb08ebc9 is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch wrapper_type_pkgs, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit 5cd8c9c into nix-community:main Oct 11, 2024
4 checks passed
@mergify mergify bot temporarily deployed to github-pages October 11, 2024 20:37 Inactive
@MattSturgeon MattSturgeon deleted the wrapper_type_pkgs branch October 11, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] home-manager nixvim type getSubOptions errors with attribute 'pkgs' missing
2 participants