tests: fixes & refactoring for nixpkgs-module #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than getting `runCommand` from the pkgs instance under test, get the function from a fixed/consistent pkgs instance.
Instead of importing the full set of top-level nixvim modules, only import the nixpkgs-module and its direct dependencies.
MattSturgeon
force-pushed
the
nixpkgs_cleanup
branch
from
e21f13b to
d4c6776
Compare
khaneliman
approved these changes
Jan 16, 2025
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d4c6776 |
|
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to reduce the scope of #2738, I've extracted a handful of the refactoring, minor fixes, and general prep commits into this PR.