Skip to content

Conversation

FredeHoey
Copy link
Contributor

@FredeHoey FredeHoey commented Aug 26, 2025

Adds https://github.com/t-troebst/perfanno.nvim

perfanno-nvim was just recently added to nixpkgs, so cannot be merged until flake.lock is updated

see NixOS/nixpkgs#436798

@FredeHoey FredeHoey changed the title Draft: plugins/perfanno: add perfanno-nvim plugin plugins/perfanno: add perfanno-nvim plugin Aug 30, 2025
@FredeHoey FredeHoey force-pushed the plugins/perfanno/init branch 2 times, most recently from f1a79c0 to 7355b55 Compare August 30, 2025 16:49
@MattSturgeon
Copy link
Member

error: vimPlugins.perfanno-nvim cannot be found in pkgs

Looks like the package isn't in the currently pinned nixpkgs revision. I can see it on nixos search, so you may need to wait for us to update the lockfile.

@FredeHoey
Copy link
Contributor Author

@MattSturgeon Yes I upstreamed the package :) I just put this here for when upstream is updated. When do you reckon that will happen?

@FredeHoey FredeHoey force-pushed the plugins/perfanno/init branch from 7355b55 to 29544e5 Compare August 30, 2025 20:21
@MattSturgeon
Copy link
Member

When do you reckon that will happen?

#3647 currently has several issues that need fixing or suppressing before we can update, so "when" is currently unclear 😢

@FredeHoey
Copy link
Contributor Author

@MattSturgeon Totally fine :) LMK if there's something I can do

@MattSturgeon
Copy link
Member

MattSturgeon commented Aug 30, 2025

LMK if there's something I can do

We "just" need someone to go through each failure and disable the relevant failing tests. Or if disabling our tests isn't appropriate, we may need to fix the issues uncovered by our CI upstream in nixpkgs.

This isn't always fun or easy, especially when using buildbot and needing to navigate from cached build failures back to the original build that has the error logs...

Sometimes local building/evaluating/debugging is also needed.

I'm sure we'll get to it eventually. You can see @GaetanLepage has already made a start with plugins/project-nvim: fix moduleName.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants