Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm override workaround for eth-utils #1881

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jan 1, 2025

to avoid attribute 'override' missing error when bump nixpkgs to 25.05, for more info

Contribution checklist (recommended but not always applicable/required):

  • There's an automated test for this change
  • Commit messages or code include references to related issues or PRs (including third parties)
  • Commit messages are conventional - examples from the log include "feat: add changelog files to fixup hook", "fix(contourpy): allow wheel usage", and "test: add sqlalchemy2 test"

@elikoga
Copy link
Contributor

elikoga commented Jan 2, 2025

I don't see how crypto-org-chain/ethermint#569 is related when looking over the diff.

Originally this was introduced by #1176 in response to #1161.

From the wording in #1176 it sounds to me like this change would be a welcome change since (if it works) it should remove the workaround.

Ideally we can add the original or a new reproduction/integration test to ./tests.

@mmsqe
Copy link
Contributor Author

mmsqe commented Jan 2, 2025

since eth-hash fix the cycle issue since v0.3.2, not sure if we still need fix the override?

@mmsqe mmsqe changed the title fix: rm overwrite for eth-utils fix: rm override workaround for eth-utils Jan 3, 2025
@mmsqe
Copy link
Contributor Author

mmsqe commented Jan 3, 2025

Just added eth-utils-test to reproduce attribute 'override' missing error, see if it's ok @elikoga

@Nebucatnetzer Nebucatnetzer merged commit 058cce6 into nix-community:master Jan 7, 2025
192 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants