Skip to content

kubecolor: omit preset instead of declaring empty string - #2476

Merged
trueNAHO merged 1 commit into
nix-community:masterfrom
trueNAHO:kubecolor-omit-preset-instead-of-declaring-empty-string
Aug 12, 2026
Merged

kubecolor: omit preset instead of declaring empty string#2476
trueNAHO merged 1 commit into
nix-community:masterfrom
trueNAHO:kubecolor-omit-preset-instead-of-declaring-empty-string

Conversation

@trueNAHO

Copy link
Copy Markdown
Member
Fixes: 74ee1ed5057e ("kubecolor: init (#657)")

@ajgon, could you verify whether this is semantically equivalent and works in all cases? If lib.mkIf is unsupported in this context, lib.optionalString could be used instead.


@stylix-automation stylix-automation Bot added topic: home-manager Home Manager target topic: modules /modules/ subsystem labels Aug 11, 2026
@stylix-automation
stylix-automation Bot requested a review from ajgon August 11, 2026 14:12
@ajgon

ajgon commented Aug 11, 2026

Copy link
Copy Markdown
Member

@trueNAHO checked and verified, lib.mkIf is fine in this case - for either it will drop the preset line, which kubecolor handles without any issue.

@trueNAHO
trueNAHO merged commit 1e6ccad into nix-community:master Aug 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: home-manager Home Manager target topic: modules /modules/ subsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants