feat: add nixf-tidy and statix linters for comprehensive Nix code quality#66
Open
lessuselesss wants to merge 3 commits into
Open
feat: add nixf-tidy and statix linters for comprehensive Nix code quality#66lessuselesss wants to merge 3 commits into
lessuselesss wants to merge 3 commits into
Conversation
- Fix local variable usage outside functions - Remove unused variables to pass shellcheck - Improve ANSI color removal with proper sed usage - Rebuild Nix package with clean shellcheck validation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…lity - Add Statix linter for Nix anti-pattern detection with JSON output support - Add NixfTidy linter for semantic analysis (duplicate keys, unused variables) - Extend linter schemas with StatixReport and NixfDiagnostic types - Update LinterProvider to support 'statix' and 'nixf-tidy' linter types - Add comprehensive test coverage for both new linters - Update documentation with Statix configuration examples and usage This provides complementary Nix linting capabilities: - statix: Style linting and anti-patterns - nixf-tidy: Semantic analysis with precise line/column positioning 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replace TODO with explanatory comment about statix character positions - Document that statix only provides character offsets, not line numbers - Clarify fallback behavior for line positioning 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Hi @lessuselesss! Thanks for the PRs! I will take a look at them tomorrow, got a lot at work at the moment. :) |
Owner
|
I realize that I have dropped the ball on this. I apologize for this, got swarmed with work for a while. I'll take a look at it :) |
Owner
|
Hi @lessuselesss, Another apology for the delay here. Same situation as #65, I should have gotten to this much sooner. This one builds on #65's branch, so most of the structural feedback from there applies here too. Once #65 is sorted, the rebase on this one will be a lot simpler. For the linter-specific changes, a few things worth addressing before a proper review:
Happy to discuss any of these, especially the one-or-two linter types question. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Features Added
Statix Linter
LINTER_TYPE=statixstatix.tomlNixfTidy Linter
LINTER_TYPE=nixf-tidy--variable-lookupflagComplementary Analysis
These linters provide complementary Nix code quality checking:
Test Coverage
Documentation
Test plan
🤖 Generated with Claude Code