Add AnalysisResult class #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkanazawa1989
force-pushed
the
upgrade/replace_fitval-dev_analysis_container
branch
2 times, most recently
from
aece8c8 to
e5ff8ad
Compare
- AnalysisResultData class has been deprecated - ExperimentData.load is updated to directly instantiate own class - DbExperimentData._analysis_res_cls attribute is added to instantiate proper analysis container AnalysisResult class implements _from_service_data method that implements formatter for FitVal. UFloat value is converted into FitVal just before data saving and converted back into UFloat in the loader. Covariance info will be lost in round trip. FitVal is still supported as value container for UFloat in database service. FakeService unittest class is also udpated to support storing the analysis results and several unittests for AnalysisResult class are also added.
nkanazawa1989
force-pushed
the
upgrade/replace_fitval-dev_analysis_container
branch
from
e5ff8ad to
0bf1507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnalysisResult class implements _from_service_data method that implements
formatter for FitVal. UFloat value is converted into FitVal just before data saving
and converted back into UFloat in the loader. Covariance info will be lost in round trip.
FitVal is still supported as value container for UFloat in database service.
Summary
better gitdiff/review for analysis result class
Details and comments