Trim whitespaces from access token #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required to remove newline character at the end of the file that might be added by an editor
|
Thank you. Note I'm not sure modifying the content of such kind of file is a good idea, but ok, in practice it should not be harmful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some editors add a newline at the end of a file automatically, which currently is processed by comin.
This makes authentication at the remote fail.
As there are no newlines or other whitespace characters that are relevant, doing an input sanitization here makes sense.
Fixes #57 and probably also #38 (as Forgejo does not have a requirement for a specific username, when using an access token).