Handle 'moved' events in serve_header.py #4997
Open
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I actually stumbled on this while working with the header server during development. I had a habit of organizing my workspace by moving project folders around, and I kept noticing that serve_header.py would not pick up the changes until I restarted it. After looking at the code, I realized it was only listening for create and delete events, not moves. Since the watchdog library treats moves as their own event type with both src_path and dest_path, I figured the cleanest fix was to handle them explicitly rather than relying on separate delete/create events that might not always fire. Tested it out by moving directories in and out while the server was running, and it works great now! |
Fixes nlohmann#3659 I was testing serve_header.py with my local development setup and noticed that when I moved directories into or out of the monitored root, they weren't being picked up properly. The script would only detect create and delete events but not move operations. This was happening because the on_any_event handler only checked for 'created' and 'deleted' events on directories. Move events have a separate event type 'moved' that includes both the source and destination paths. The fix treats a move event like a combination of delete (for the source) and create (for the destination) - we rescan to remove any trees that were moved out, and add the destination directory to check for new trees that were moved in. This should make the development workflow smoother when reorganizing project directories while the server is running. Signed-off-by: Samaresh Kumar Singh <[email protected]>
ssam18
force-pushed
the
fix-serve-header-move-events-issue-3659
branch
from
000e2e8 to
4b8db07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3659
Problem
The
serve_header.pyscript wasn't detecting when directories were moved into or out of the monitored root directory. This made the development workflow less smooth when reorganizing projects while the server was running.Root Cause
The
on_any_eventhandler only processed'created'and'deleted'events for directories, but file system watchers emit a separate'moved'event type that includes both source and destination paths.Solution
Added handling for
'moved'events on directories by treating them as a combination of:This mirrors how the filesystem actually handles move operations and ensures the working tree list stays in sync.
Testing
I tested this locally by:
The fix maintains backward compatibility and doesn't change behavior for other event types.