Add rename modal and persistent identity with connect update - #2
Open
noahfraiture wants to merge 1 commit into
Open
Add rename modal and persistent identity with connect update#2noahfraiture wants to merge 1 commit into
noahfraiture wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
connectrequest with the same token to update the name for an existing identity.Description
displayNameandonRenameAPI (filefrontend/src/TopBar.tsx).localStorageand expose helpers to load/save identity and create a token (filefrontend/src/main.tsx).connectrequest over the WebSocket on load and when the name is changed using the existinguseWsRequesthelper (filefrontend/src/main.tsx).frontend/src/App.tsx).Testing
pnpm installand the install step completed successfully.vite) and confirmed the app served locally (HTTP 200 response), which succeeded.artifacts/rename-modal.png), which succeeded.Codex Task