feat: Moving won't stop when the mouse goes out of the canvas

nocpiun · Dec 10, 2023 · b11b345 · b11b345 · github-actions · Dec 10, 2023
1 parent 45b68d7
commit b11b345
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 14 deletions.
diff --git a/src/renderer/Render.ts b/src/renderer/Render.ts
@@ -146,11 +146,6 @@ export default class Render {
         this.stopMoving();
     }
 
-    public handleMouseLeave(): void {
-        this.stopMoving();
-        this.mousePoint = this.center;
-    }
-
     public handleWheel(dy: number): void {
         const delta = 7;
         const mouseOriginPoint = this.mousePoint.toCoordinates();

diff --git a/src/views/graphing/index.tsx b/src/views/graphing/index.tsx
@@ -86,7 +86,7 @@ const Graphing: React.FC = memo(() => {
             if(!workerRef.current) return;
             workerRef.current.postMessage({ type: "mouse-down", rect: canvas.getBoundingClientRect(), cx: e.clientX, cy: e.clientY });
         });
-        canvas.addEventListener("mousemove", (e: MouseEvent) => {
+        window.addEventListener("mousemove", (e: MouseEvent) => {
             if(!workerRef.current) return;
 
             var direction: MovingDirection;
@@ -98,14 +98,10 @@ const Graphing: React.FC = memo(() => {
 
             workerRef.current.postMessage({ type: "mouse-move", rect: canvas.getBoundingClientRect(), cx: e.clientX, cy: e.clientY, direction });
         });
-        canvas.addEventListener("mouseup", () => {
+        window.addEventListener("mouseup", () => {
             if(!workerRef.current) return;
             workerRef.current.postMessage({ type: "mouse-up" });
         });
-        canvas.addEventListener("mouseleave", () => {
-            if(!workerRef.current) return;
-            workerRef.current.postMessage({ type: "mouse-leave" });
-        });
         canvas.addEventListener("wheel", (e: WheelEvent) => {
             if(!workerRef.current) return;
             workerRef.current.postMessage({ type: "wheel", dy: e.deltaY });

diff --git a/src/workers/graphing.worker.ts b/src/workers/graphing.worker.ts
@@ -41,9 +41,6 @@ ctx.addEventListener("message", (e) => {
         case "mouse-up":
             renderer.handleMouseUp();
             break;
-        case "mouse-leave":
-            renderer.handleMouseLeave();
-            break;
         case "wheel":
             renderer.handleWheel(req.dy);
             break;