Use existing pingCheckProcess while in full & limited states. #1167
+13
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced switch statement with cleaner if-else logic for connected status - Removed raw 'none'/'unknown' status text exposure - Properly handle 'portal', 'connected', and 'limited' states based on service properties
…ping This ensures that even when nmcli reports 'full' connectivity, an actual ping check is performed to verify internet access. It also refactors the connectivity check loop to update status and trigger scans immediately on state changes.
Contributor
Author
|
I need to know what i can do and what i can't do.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Motivation
I didn't noticed pingCheckProcess is unused, i found out today (my DNS Server crashed) | meantime I noticed doesn't work it didn't showed like i intended to.
(PS: My bad i should've noticed this before)
Type of Change
Mark the relevant option with an "x".
Testing
quickshell -vv -p shell.qml > "debug_$(date +%Y-%m-%d_%H-%M-%S).log" is running on background, i see my changes after reload delay.
Checklist
Additional Notes
connectivityCheckTimer 15s I didn't changed but might be too short for connectivity check.
Also may cause too frequent pinging/spam behavior, might need somewhat smarter connectivity check logic...