Skip to content

Resolved an issue preventing plugin from working correctly #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolved an issue preventing plugin from working correctly #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 30 additions & 18 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exports.register = function(app) {
var logger = app.lib.logger('projects reloader');

// start file watcher for reloading projects on change
var syncProject = function(filename, fileInfo) {
var addOrChangeProject = function(filename) {
var projectName = path.relative(
app.config.paths.projects,
path.dirname(filename)
Expand All @@ -18,33 +18,45 @@ exports.register = function(app) {
app.projects.unload({name: projectName});
}

// on add or change (info is falsy on unlink)
if (fileInfo) {
logger.log('Load project "' + projectName + '" on change');
app.projects.load({name: projectName}, function(err) {
if (err) {
return logger.error(
'Error during load project "' + projectName + '": ',
err.stack || err
);
}
logger.log(
'Project "' + projectName + '" loaded:',
JSON.stringify(app.projects.get(projectName), null, 4)
logger.log('Load project "' + projectName + '" on change');
app.projects.load({name: projectName}, function(err) {
if (err) {
return logger.error(
'Error during load project "' + projectName + '": ',
err.stack || err
);
});
}
logger.log(
'Project "' + projectName + '" loaded:',
JSON.stringify(app.projects.get(projectName), null, 4)
);
});
};

var unlinkProject = function(filename) {
var projectName = path.relative(
app.config.paths.projects,
path.dirname(filename)
);

if (app.projects.get(projectName)) {
logger.log('Unload project: "' + projectName + '"');
app.projects.unload({name: projectName});
}
};



// NOTE: currently after add remove and then add same file events will
// not be emitted
var watcher = chokidar.watch(
path.join(app.config.paths.projects, '*', 'config.*'),
{ignoreInitial: true, depth: 1}
);
watcher.on('add', syncProject);
watcher.on('change', syncProject);
watcher.on('unlink', syncProject);
watcher.on('add', addOrChangeProject);
watcher.on('change', addOrChangeProject);
watcher.on('unlink', unlinkProject);


watcher.on('error', function(err) {
logger.error('File watcher error occurred: ', err.stack || err);
Expand Down